[PATCH] D114457: [z/OS] Implement prologue and epilogue generation for z/OS target.

[Neumann Hon via Phabricator via llvm-commits]

Everybody0523 added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp:1190
+
+  // Arguments are located in the parent's frame. To identify this situation it
+  // is enough to check if the frame index refers to a fixed object.
----------------
uweigand wrote:
> In particular, this looks quite wrong.   It's true with most ABIs that arguments are in the parent's frame, but that should have been handled elsewhere, it shouldn't require special code in this routine.
Should this be done in LowerFormalArguments instead? I'm sorry but I'm not quite sure where else to do it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114457/new/

https://reviews.llvm.org/D114457