[PATCH] D111460: [X86][LoopVectorize] "Fix" `X86TTIImpl::getAddressComputationCost()`

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 10:53:35 PST 2021


lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.

In D111460#3158819 <https://reviews.llvm.org/D111460#3158819>, @rengolin wrote:

> I can't predict if the new shuffle patterns will be better or worse on each affected platform, least of all looking at IR, not ASM.
>
> But if those changes have positive changes in code generation (translating to better benchmark numbers), then this looks good to me.

Thank you for chiming in and confirming my understanding!
I'll land this tomorrow, unless there's further comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111460/new/

https://reviews.llvm.org/D111460



More information about the llvm-commits mailing list