[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Mon Nov 29 09:35:21 PST 2021

aaron.ballman added a comment.

In D114639#3158401 <https://reviews.llvm.org/D114639#3158401>, @RKSimon wrote:

>> Have you checked whether there are any bots in the lab that will need to be updated?
>
> I did find a number of bots that I think need addressing, I am intending to privately email the owners but I haven't done that yet - @rnk maintains the sanitizer-windows and windows-gcebot2 machines, but there are others.

Thanks! I think we'll need the bot situation sorted out before we land this, otherwise we'll have bots red and failing to report newly introduced regressions from other patches. (Hopefully we'll replace the bots with ones that test newer VS configurations rather than lose the coverage entirely.)

================
Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:17-18
+# _MSC_VER == 1929 MSVC++ 14.29 Visual Studio 2019 Version 16.10 & 16.11
+set(MSVC_MIN 19.20)
+set(MSVC_SOFT_ERROR 19.29)

----------------
RKSimon wrote:
> aaron.ballman wrote:
> > I'm a bit less certain that this is reasonable. 16.11.0 is from August 2021, which seems incredibly new for giving soft errors on.
> Our docs do say the latest update of the compiler, but I take your point.
> 
> 16.10 (same _MSC_VER) was released in May 2021
> https://docs.microsoft.com/en-us/visualstudio/install/visual-studio-build-numbers-and-release-dates?view=vs-2019
> 
> If we want something a year old, 16.8 + 16.9 (1928) is about right.
16.7 (1927) would also be quite reasonable (Aug 2020). I don't have a strong preference for 16.7 vs 16.8, so I took a look at the release notes. 16.8 added support for newer C++ features, but not ones we care about consuming in our code base (coroutines, concepts, <ranges>, some STL improvements, etc), so I think we'd be fine with 16.7 if we wanted to be more conservative on the window for the soft error.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114639/new/

https://reviews.llvm.org/D114639