[PATCH] D114709: [Flang] Upstream conversion of the XRebox Op

[Jean Perier via Phabricator via llvm-commits]

jeanPerier added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1787
+         ++i, ++strideOps, ++shiftOps, sliceOps += 3) {
+      auto sliceLb = integerCast(loc, rewriter, idxTy, operands[sliceOps]);
+      auto inputStride = *strideOps; // already idxTy
----------------
clementval wrote:
> kiranchandramohan wrote:
> > @jeanPerier  Here and in a few other places we were using the original operands and not the converted operands. This caused some issue when I cherry-picked the patch to llvm-project/flang. In discourse it was pointed out that this is because we are not using the converted operands (https://llvm.discourse.group/t/issue-in-conversion-from-index-to-i64/4853). Is there any reason we were using the original operands? 
> > For getting the patch to work I had to switch to the converted operands.
> 
> Is there any reason we were using the original operands?

No, I think I just did not realize I was not using the converted ones and it just worked. Thanks for catching this and fixing it.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114709/new/

https://reviews.llvm.org/D114709