[PATCH] D114201: [LTO] Add a function `LTOCodeGenerator::getMergedModule`
Steven Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 29 09:01:36 PST 2021
steven_wu requested changes to this revision.
steven_wu added a comment.
This revision now requires changes to proceed.
Few things to improve before commit:
- Drop the words like "in my case", "I", etc. from the commit message. Eg, `In my case, after optimize is called, I need to access the underlying module to get information.` can be rewritten as `API can be used to access the underlying module to get information after optimized is called`. It would sound much better.
- Please add a use-case of the API in test suite otherwise it can be removed as dead code. You can look into getting it used in `llvm-lto` tool and add a testcase to exercise the code path.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114201/new/
https://reviews.llvm.org/D114201
More information about the llvm-commits
mailing list