[PATCH] D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:892
+    if (!IsPPC64)
+      assert(MO.isGlobal() && "Invalid operand for ADDItoc.");
+    else
----------------
minor nit: no need to have an if/else for this. We don't have to be too formal with assert messages and having "Invalid operand for ADDItoc[8]." is fine.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5833
 
-    assert((isPPC64 || (isAIXABI && !isPPC64)) && "We are dealing with 64-bit"
-           " ELF/AIX or 32-bit AIX in the following.");
----------------
Minor nir: I'm guessing this changed because you ran clang-format on the whole file? We try not to touch otherwise unchanged lines. Can you put it back to what it originally was.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114654/new/

https://reviews.llvm.org/D114654