[PATCH] D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 06:46:38 PST 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:1474
+    if (Op == SIMemOp::STORE)
+      Changed |= enableGLCBit(MI);
     Changed |= enableSLCBit(MI);
----------------
foad wrote:
> Does this change the documented code sequences: https://llvm.org/docs/AMDGPUUsage.html#amdgpu-amdhsa-memory-model-code-sequences-gfx10-table ?
D114707


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114351/new/

https://reviews.llvm.org/D114351



More information about the llvm-commits mailing list