[PATCH] D108699: [LAA] Analyze pointers forked by a select

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 04:53:52 PST 2021


david-arm accepted this revision.
david-arm added a comment.

LGTM!

Hi @huntergr, thanks for making all the changes. I think the patch looks good to
go for now. It's still worth looking into the MemAccessInfo approach as a follow-up,
but the patch has been sat in review for long enough (3 months) without any
fundamental objections so I'd prefer we got something merged now to get the
functionality defended and unblock future work. This is currently only enabled
under an option, so any refactoring for the MemAccessInfo approach can be
done safely under another patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108699/new/

https://reviews.llvm.org/D108699



More information about the llvm-commits mailing list