[PATCH] D111337: [fir] Add array value copy pass

Mon Nov 29 04:51:47 PST 2021

clementval marked an inline comment as done.
clementval added a comment.

In D111337#3155551 <https://reviews.llvm.org/D111337#3155551>, @kiranchandramohan wrote:

> In D111337#3154805 <https://reviews.llvm.org/D111337#3154805>, @mehdi_amini wrote:
>
>> @kiranchandramohan do you plan on reviewing/approving the current version of the patch?
>>
>> I don't have any more comment than before, there are just a few that are still pending.
>
> The patch LGTM. Thanks for going through the patch in detail and pointing out various issues. And thanks to @clementval for addressing most of the issues. I agree that the remaining issues can be dealt with later. I have created a few github issues to follow up on later work.
>
> Nit: The changes in the following files are in other patches or have been merged. How are you planning to handle this?
> flang/lib/Optimizer/Dialect/FIRType.cpp
> flang/include/flang/Optimizer/Builder/Runtime/RTBuilder.h
> flang/include/flang/Optimizer/Builder/Runtime/Assign.h
> flang/lib/Optimizer/Builder/Runtime/Assign.cpp

@kiranchandramohan I'm just gonna rebase on main since some of the patch have landed and I'll merge in the change requested from this review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111337/new/

https://reviews.llvm.org/D111337