[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

[Dylan McKay via Phabricator via llvm-commits]

dylanmckay added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:2113
+  MI.setDesc(TII->get(AVR::STDPtrQRr));
+  MI.getOperand(0).setReg(STI.getFrameLowering()->hasReservedCallFrame(MF) ? AVR::R29R28 : AVR::R31R30);
+
----------------
dylanmckay wrote:
> Recommend you split the logic `STI.getFrameLowering()->hasReservedCallFrame(MF) ? AVR::R29R28 : AVR::R31R30` into a method, with some reasonable name like `getStackStoreBaseRegister
I thought I deleted this comment as I changed my mind. Please ignore - there is no need to split it into a method


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114611/new/

https://reviews.llvm.org/D114611