[PATCH] D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr

Mon Nov 29 03:27:01 PST 2021

dylanmckay abandoned this revision.
dylanmckay added a comment.

I'm going to close this in favor of https://reviews.llvm.org/D114611 . I agree with Matt's comments about there being a bit of funny business going on in this PR, the concept is being generalized in core unnecessarily and does not strictly make sense in the place I put it. I think the approach in this other patch (thanks @Patryk27) is much more sensible.

Thanks for the reviews everybody. Very well thought out.

Also thanks for chiming in @mhjacobson, that is exactly where I was coming from. Well articulated. The conclusion about moving it to `AVRExpandPseudoInsts` is a good one that I don't think I made it to when I last looked at this some time ago (too long ago - I know!).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95664/new/

https://reviews.llvm.org/D95664