[PATCH] D108371: [LAA] Add Memory dependence and unknown bounds remarks.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/include/llvm/Analysis/LoopAccessAnalysis.h:304
+  /// Used for generating optimization remarks.
+  std::shared_ptr<Dependence> UnsafeDependence;
+
----------------
Does this need to be a `shared_ptr`? If you want to encode the fact that it may not be set, using `Optional` may be a better choice. Or you could initialize it to `NoDep` in case there is no unsafe dependence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108371/new/

https://reviews.llvm.org/D108371