[PATCH] D114378: [DebugInfo][7/N][InstrRef] Preserve indirectness when restoring variable locations

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:547-550
       const DIExpression *Expr = ActiveVLocIt->second.Properties.DIExpr;
-      DbgValueProperties Properties(Expr, false);
+      bool IsIndirect = ActiveVLocIt->second.Properties.Indirect;
+      DbgValueProperties Properties(Expr, IsIndirect);
       PendingDbgValues.push_back(MTracker->emitLoc(NewLoc, Var, Properties));
----------------
Maybe nit: Could you just copy `ActiveVLocIt->second.Properties` instead? Not a strong opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114378/new/

https://reviews.llvm.org/D114378