[PATCH] D114477: [fir] Add fir numeric intrinsic runtime call builder

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/Builder/Runtime/Numeric.cpp:286
+  else
+    fir::emitFatalError(loc, "unsupported REAL kind in Nearest lowering");
+
----------------
rovka wrote:
> Nit: Some places use TODO, some use fir::emitFatalError. Should we settle on just one of them?
I switched to ` fir::emitFatalError` where it was a  TODO. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114477/new/

https://reviews.llvm.org/D114477