[PATCH] D112758: [llvm] [Debuginfo] Debuginfod client library.

[Pavel Labath via Phabricator via llvm-commits]

labath added inline comments.


================
Comment at: llvm/include/llvm/Debuginfod/Debuginfod.h:42
+/// DEBUGINFOD_TIMEOUT environment variable, default is 90 seconds (90000 ms).
+long getDefaultDebuginfodTimeoutMS();
+
----------------
how about returning `std::chrono::milliseconds` instead?


================
Comment at: llvm/lib/Debuginfod/Debuginfod.cpp:32
+
+namespace llvm {
+// Returns a binary BuildID as a normalized hex string.
----------------
Now you have both a `using llvm` declarating and you're putting everything inside the llvm namespace as well. :)


================
Comment at: llvm/lib/Debuginfod/Debuginfod.cpp:148
+  Client.setTimeout(Timeout);
+  for (const StringRef &ServerUrl : DebuginfodUrls) {
+    SmallString<64> ArtifactUrl;
----------------
since we're passing them by value, I'd say we can also iterate over them in this way...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112758/new/

https://reviews.llvm.org/D112758