[PATCH] D114641: [LNT] Remove `nm` dependency, used `objdump –t` instead

[Tamar Christina via Phabricator via llvm-commits]

tnfchris accepted this revision.
tnfchris added a comment.
This revision is now accepted and ready to land.

The code itself looks fine to me,

> Wrong nm can provide an information but addresses may be wrong. The correct nm for ARM will report the address 0x1234 for a thumb binary, but system’s nm (x86) will report the address 0x1235.

Right since `nm` only reads the ELF header and doesn't need to understand the object format first, so it's unable to strip the Thumb bit as it has no concept of Thumb.
But objdump does need to understand it, for better or worse..

So by depending on `objdump` it does mean you can only really support one target at once (unless you have an objdump built with support for al bfd targets).
Looks like that's not a new change in this Diff. but something we might want to change in the future.


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114641/new/

https://reviews.llvm.org/D114641