[PATCH] D95142: [SLC] Simplify strcpy and friends with non-zero address spaces

Mindong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 28 19:05:35 PST 2021


mdchen added a comment.

> The pointee type is meaningless in the IR and will be going away.

@arsenm @arichardson Hi, this change let user-defined string functions(e.g., `size_t strlen(int*)`) pass the check and considered a libfunc, which can cause failure in later optimizations like `optimizeStrLen` which assumes `CharSize` is 8. And pointed type does matter in this case. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95142/new/

https://reviews.llvm.org/D95142



More information about the llvm-commits mailing list