[PATCH] D114324: [LV] Move code from vectorizeMemoryInstruction to recipe's execute().

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 28 13:53:24 PST 2021


Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9926
+      if (Reverse)
+        NewLI = Builder.CreateVectorReverse(NewLI, "reverse");
+    }
----------------
The `assert(Vec->getType()->isVectorTy() && "Invalid type");` of reverseVector() being dropped will be taken care of by Builder.CreateVectorReverse() anyhow?


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9934
+  /*&Ingredient, State, StoredValue ? nullptr : getVPSingleValue(), getAddr(),*/
+  /*StoredValue, getMask(), Consecutive, Reverse);*/
 }
----------------
clean up above comments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114324/new/

https://reviews.llvm.org/D114324



More information about the llvm-commits mailing list