[PATCH] D113717: [Symbolizer][Debuginfo] Add debuginfod client to llvm-symbolizer.

Noah Shutty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 28 10:07:00 PST 2021


noajshu added a comment.

@dblaikie thanks for your suggestion to add tests. I just added regression test coverage checking that the symbolizer can query a local debuginfod server (using a python simple http server).
I also added unit tests to D112758 <https://reviews.llvm.org/D112758> checking that the local cache is used correctly.
I made one small change to the client library, which is to respect the `DEBUGINFOD_CACHE_PATH` and `DEBUGINFOD_TIMEOUT` env variables in addition to `DEBUGINFOD_URLS`.
Please let me know if you have thoughts on the testing strategy or any other feedback on this diff stack (D112751 <https://reviews.llvm.org/D112751>, D112753 <https://reviews.llvm.org/D112753>, D112758 <https://reviews.llvm.org/D112758>, and D113717 <https://reviews.llvm.org/D113717>).
If this looks good I can update D112759 <https://reviews.llvm.org/D112759> to use this same python test script.
Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113717/new/

https://reviews.llvm.org/D113717



More information about the llvm-commits mailing list