[PATCH] D114321: [LV] Move code from widenGEP to VPWidenGEPRecipe (NFC).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 28 08:20:02 PST 2021


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Nice inlining! Looks good to me, with a minor nit.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:563
 
+  /// Similar to the previous function but it adds the metadata to a
+  /// vector of instructions.
----------------
Better keep both addMetadata() methods next to each other; the one left below is not more "protected" than this one, plus their documentations are linked - above refers to the "previous function" below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114321/new/

https://reviews.llvm.org/D114321



More information about the llvm-commits mailing list