[PATCH] D114386: [InstCombine] use decomposeBitTestICmp to make icmp (trunc X), C more consistent

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D114386#3157092 <https://reviews.llvm.org/D114386#3157092>, @spatel wrote:

> In D114386#3155303 <https://reviews.llvm.org/D114386#3155303>, @lebedev.ri wrote:
>
>> LGTM, sorry for the delay, i like this.
>
> Thanks for the suggestion and review! Let's see if this causes any fallout...

I still think the other patterns should also migrate into `decomposeBitTestICmp()`.
If you don't want to update every single caller, you can always keep the old declaration
around, and make it a wrapper for the new function, and return false if the rhs constant is non-zero.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114386/new/

https://reviews.llvm.org/D114386