[PATCH] D114194: [SystemZ] Add range checks for PC-relative fixups

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

The code changes LGTM.

> I copied the diagnostic message from GAS in fixups-out-of-range-02.s, but have not done so for the displacements (fixups-out-of-range-01.s). I am not quite sure what is best: should the displacements also get the fuller diagnostic, or is it better with a simplistic message?

I think it's better to be explicit, so the message for displacements should mirror the one here.

As to the test, I don't really like the checking for explicit line:column numbers - this will make those test awkward to change in the future.   Isn't it enough to identify a particular line by the label number used in it (assuming you make label uses unique, which can be easily done by sometimes putting two labels on the same location).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114194/new/

https://reviews.llvm.org/D114194