[PATCH] D114304: [X86][FP16] Replace vXi16 to vXf16 instead of v8f16

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 28 04:31:14 PST 2021


pengfei added a comment.

In D114304#3144642 <https://reviews.llvm.org/D114304#3144642>, @RKSimon wrote:

> Which of the patterns that you changed is actually causing the crash and is it possible to create a test case for the other?

The pattern is `MaskVT == MVT::v16i16` and `Mask = {0, -2, -2, ..., -2}`. It matches the conditions in line 36273 and 36274. I tried several times but failed to generate `Mask = {0, -1, -1, ..., -1}` to match the condition in line 36220.
The conditions in line 36221 and 36222 are only avaliable for `MaskVT == MVT::v8i16`. So I didn't create another test cast.

In D114304#3156949 <https://reviews.llvm.org/D114304#3156949>, @LuoYuanke wrote:

> LGTM, pls address Simon's comments.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114304/new/

https://reviews.llvm.org/D114304



More information about the llvm-commits mailing list