[PATCH] D114633: [SCEV] Turn validity check in getExistingSCEV into assert (NFC).

Sat Nov 27 05:37:25 PST 2021

fhahn added a comment.

In D114633#3156405 <https://reviews.llvm.org/D114633#3156405>, @nikic wrote:

> LGTM, now that D113349 <https://reviews.llvm.org/D113349> is relanded. I'll abandon D114260 <https://reviews.llvm.org/D114260> as the request there was to keep the assert, which is exactly what you did here.

Sounds good  & thanks for linking the related patches, I missed them!

If I understand @mkazantsev's comment for D114260 <https://reviews.llvm.org/D114260> correctly, we could still remove the check after the assert has been active for a while, to catch any potential offenders. So perhaps we could land D114260 <https://reviews.llvm.org/D114260> in a month or 2?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114633/new/

https://reviews.llvm.org/D114633