[PATCH] D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 16:40:15 PST 2021


MaskRay added a comment.

IIRC the edit history is about `opting out the -z start-stop-gc` => `opting in the -z nostart-stop-gc`, or just because I made a typo.
I edited it because with the presence of negative meaning option (`nostart-stop-gc`), opt-out/opt-in can be ambiguous.

You never provide sufficient evidence to justify the  `-z nostart-stop-gc` default.

Well, I can provide evidence why the `-z start-stop-gc` behavior (7 months in origin/main now, matching GNU ld<2015-10) sticks:

> There are anecdotal or non-anecdotal evidences that many groups are fine with the -z start-stop-gc default (matching GNU ld<2015-10): Android, Chrome OS (Linux), Fuchsia, Google, Meta, SN systems, some Gentoo Linux users I asked using -fuse-ld=lld (with or without using Clang), all gn build users, all Bazel build users.



> This patch was misleadingly presented as doing what you had asked when it does the opposite

I don't think it is misleading. I disagree with your claim about the `-z nostart-stop-gc` default. You can find my previous replies: it's all the same standpoint.
I did want to pull myself out of the needless discussion at one point (that's when I said I was fine with `-z start-stop-gc` in 13.* default).
Since you never listen to others, so you think it is misleading.

If you use words like "malicious", I don't think we can have constructive discussions, either.
It's so bad waste of my time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114186/new/

https://reviews.llvm.org/D114186



More information about the llvm-commits mailing list