[PATCH] D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-netbsd-core.test:15
+    Notes:
+      - Name: NetBSD-CORE 
+        Type: NT_NETBSDCORE_PROCINFO
----------------
Delete trailing space


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5462
   }
+  if (Name.startswith("NetBSD-CORE") && ELFType == ELF::ET_CORE) {
+    StringRef Result = FindNote(NetBSDCoreNoteTypes);
----------------
Is it `startswith`? The test doesn't have a case for `NetBSD-CORE` with a suffix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114635/new/

https://reviews.llvm.org/D114635