[PATCH] D110076: [AMDGPU][GlobalISel] Code quality: Combine V_RSQ

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 08:30:24 PST 2021


foad accepted this revision.
foad added a comment.

LGTM, thanks!



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:234
+          .addUse(SqrtSrcMI->getOperand(0).getReg())
+          .setMIFlags(MI.getFlags());
+    };
----------------
I'm not sure whether it's best to copy flags from MI or RcpSrcMI or somehow combine both. I guess this is fine for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110076/new/

https://reviews.llvm.org/D110076



More information about the llvm-commits mailing list