[PATCH] D114644: [AMDGPU] Aggressively fold immediates in SIShrinkInstructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 08:09:54 PST 2021


foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/madmk.ll:34-35
 ; GCN-DAG: buffer_load_dword [[VC:v[0-9]+]], {{v\[[0-9]+:[0-9]+\]}}, {{s\[[0-9]+:[0-9]+\]}}, 0 addr64 offset:8
-; GCN-DAG: s_mov_b32 [[SK:s[0-9]+]], 0x41200000
-; GCN-DAG: v_mac_f32_e32 [[VB]], [[SK]], [[VA]]
-; GCN-DAG: v_mac_f32_e32 [[VC]], [[SK]], [[VA]]
+; GCN-DAG: v_mac_f32_e32 [[VB]], 0x41200000, [[VA]]
+; GCN-DAG: v_mac_f32_e32 [[VC]], 0x41200000, [[VA]]
 ; GCN: s_endpgm
----------------
Not a regression, but it's a bit sad that we don't form madmk here either before or after this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114644/new/

https://reviews.llvm.org/D114644



More information about the llvm-commits mailing list