[PATCH] D114363: [ThreadPool] Do not return shared futures.

Daniel McIntosh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 07:45:40 PST 2021


DanielMcIntosh-IBM added a comment.

> Are you sure? IIUC the problem was the change to not using shared_future. It built fine with `LLVM_ENABLE_THREADS=Off` with *this* patch.

No, I was mistaken. I assumed that since it was still broken after rGfb46e64a013a2c7457db3312da07db1b25ad5219 <https://reviews.llvm.org/rGfb46e64a013a2c7457db3312da07db1b25ad5219>, this also needed to be reverted. Looks like the problem was actually solved by bc41653a1f289a63a1472b7364437515c9659f77 <https://reviews.llvm.org/rGbc41653a1f289a63a1472b7364437515c9659f77> though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114363/new/

https://reviews.llvm.org/D114363



More information about the llvm-commits mailing list