[PATCH] D114477: [fir] Add fir numeric intrinsic runtime call builder

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: flang/lib/Optimizer/Builder/Runtime/Numeric.cpp:286
+  else
+    fir::emitFatalError(loc, "unsupported REAL kind in Nearest lowering");
+
----------------
Nit: Some places use TODO, some use fir::emitFatalError. Should we settle on just one of them?


================
Comment at: flang/unittests/Optimizer/Builder/Runtime/NumericTest.cpp:56
+  mlir::Value nearest = fir::runtime::genNearest(builder, loc, x, s);
+  checkCallOp(nearest.getDefiningOp(), fctName, 2, /*addLocArg=*/false);
+}
----------------
Can we also check the SelectOp and CmpFOp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114477/new/

https://reviews.llvm.org/D114477