[PATCH] D114580: [AArch64][SVE] Mark fixed-type FP extending/truncating loads/stores as custom
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 26 03:49:00 PST 2021
paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:18593-18594
EVT ContainerVT = getContainerForFixedLengthVector(DAG, VT);
+ EVT ExtendVT = ContainerVT.changeVectorElementType(
+ Load->getMemoryVT().getVectorElementType());
+ EVT LoadVT = ContainerVT;
----------------
You could move this into the if block where it's used.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:18689-18690
EVT ContainerVT = getContainerForFixedLengthVector(DAG, VT);
+ EVT ExtendVT = ContainerVT.changeVectorElementType(
+ Store->getMemoryVT().getVectorElementType());
+ EVT MemVT = Store->getMemoryVT();
----------------
Perhaps `TruncVT`? Plus as above this could be moved into the if block where it is used.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:18696
+
+ if (ContainerVT.getVectorElementType().isFloatingPoint() &&
+ Store->isTruncatingStore()) {
----------------
As above this can be just `VT`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114580/new/
https://reviews.llvm.org/D114580
More information about the llvm-commits
mailing list