[PATCH] D114499: [GlobalISel] Fold or of shifts to funnel shifts.

[Abinav Puthan Purayil via Phabricator via llvm-commits]

abinavpp added a comment.

In D114499#3153099 <https://reviews.llvm.org/D114499#3153099>, @foad wrote:

> But why doesn't it already work on vectors?

We're not matching the constant splat here. D114625 <https://reviews.llvm.org/D114625> should fix this, if I haven't missed anything.

In D114499#3153099 <https://reviews.llvm.org/D114499#3153099>, @foad wrote:

> And would it be worth adding support for constant shift amounts like `(or (shl x, 20), (lshr x, 12))`?

Yes, we need to extend the pattern match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114499/new/

https://reviews.llvm.org/D114499