[PATCH] D108699: [LAA] Analyze pointers forked by a select

[Graham Hunter via Phabricator via llvm-commits]

huntergr marked 3 inline comments as done.
huntergr added inline comments.


================
Comment at: llvm/include/llvm/Analysis/LoopAccessAnalysis.h:20
 #include "llvm/Analysis/LoopAnalysisManager.h"
+#include "llvm/Analysis/ScalarEvolution.h"
 #include "llvm/Analysis/ScalarEvolutionExpressions.h"
----------------
fhahn wrote:
> Is this needed? Other SCEV types are forward-declared below, so ScalarEvolution.h doesn't need to be included.
It was there to include the 'using ForkedPointer =' definition, but moving it out of ScalarEvolution means we can just define it here.

I had hoped that we could maybe integrate it further into ScalarEvolution as a new type of SCEV, but maybe this isn't the right time -- you're correct, this will be the only user for now, so we can just keep it here until we find a case where it would be useful to have it more widely available.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108699/new/

https://reviews.llvm.org/D108699