[PATCH] D114581: [RISCV] Fix a crash in decoding LMUL in VTYPE

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 01:41:07 PST 2021


benshi001 marked 3 inline comments as done.
benshi001 added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/RISCV/vsetvli.s:5
+# CHECK:      vsetvli a1, a0, e64, m1, tu, mu
+# CHECK-NEXT: vsetvli a1, a0, e64, <reserved LMUL>, tu, mu
+# CHECK-NEXT: vsetvli a1, a0, e64, mf8, tu, mu
----------------
jrtc27 wrote:
> Is this really the right way to disassemble this? I'd expect it to just be disassembled like any other illegal instruction, not as a real instruction with some arbitrary hard-coded human-readable string injected in the middle of it. For all we know the encoding could be used for something completely different in future.
So I will decode it to <unknown>, which I think it is better than crash.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114581/new/

https://reviews.llvm.org/D114581



More information about the llvm-commits mailing list