[PATCH] D112552: [LoopVectorize] When tail-folding, don't always predicate uniform loads

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 00:51:44 PST 2021


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Please make sure to update the commit message; the current one is very much out-of-date.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1545
+  bool isPredicatedInst(Instruction *I, bool IsKnownUniform = false) {
+    if (IsKnownUniform && isa<LoadInst>(I) &&
+        !Legal->blockNeedsPredication(I->getParent()))
----------------
I think it would be good to add the explanation from your earlier comment here to help the reader.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112552/new/

https://reviews.llvm.org/D112552



More information about the llvm-commits mailing list