[PATCH] D114429: [objcopy][NFC] Add doc comments to the executeObjcopy* functions.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 00:09:56 PST 2021


jhenderson added inline comments.


================
Comment at: llvm/include/llvm/Object/ObjCopy/ELF/ELFObjcopy.h:27
+/// Applies the transformations described by \p Config and \p ELFConfig to
+/// \p In(FileFormat::IHex) and writes the result into \p Out.
+/// \returns any Error encountered whilst performing the operation.
----------------
jhenderson wrote:
> 
In this and the next case, you probably still want the full inline suggestion, as the format isn't defined by the input type (a MemoryBuffer doesn't know whether it's to be treated as IHex or raw binary, or something else entirely).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114429/new/

https://reviews.llvm.org/D114429



More information about the llvm-commits mailing list