[PATCH] D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.
Herald added a subscriber: ctetreau.


================
Comment at: llvm/trunk/test/tools/llvm-ifs/conflict-size.ifs:15
+Symbols:
+  b: { Type: Object, Size: 1 }
+...
----------------
Aplogies for asking on this patch (and very late after it was submitted), but playing with `llvm-ifs`, I see the following error running `llvm-ifs` against my copy of glibc.

```
$ llvm-ifs /lib/x86_64-linux-gnu/libc.so.6  --output-format=ELF -o -      
error: Interface Stub: Size Mismatch for sys_sigabbrev.
Filename: /lib/x86_64-linux-gnu/libc.so.6
Size Values: 512 520

$ llvm-readelf -s /lib/x86_64-linux-gnu/libc.so.6| grep sys_sigabbrev
   881: 00000000001e9d00   512 OBJECT  GLOBAL DEFAULT    27 sys_sigabbrev at GLIBC_2.2.5
   882: 00000000001e9d00   520 OBJECT  GLOBAL DEFAULT    27 sys_sigabbrev@@GLIBC_2.3.3
```
So it looks like glibc has 2 different sizes of sys_sigabbrev, but the symbols seem versioned, IIUC?  ie. one is `sys_sigabbrev at GLIBC_2.2.5` vs `sys_sigabbrev@@GLIBC_2.3.3`.

Is there an option to pick one, or perhaps both without removing the symbol versioning?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66405/new/

https://reviews.llvm.org/D66405