[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

Patryk Wychowaniec via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 25 13:12:39 PST 2021


Patryk27 created this revision.
Patryk27 added reviewers: arsenm, bogner, dylanmckay.
Patryk27 added a project: LLVM.
Herald added subscribers: Jim, hiraditya.
Patryk27 requested review of this revision.
Herald added subscribers: llvm-commits, wdng.

This takes a different approach to solve https://reviews.llvm.org/D95664: instead of hacking around `isFrameInstr()`, I've moved parts of the logic to `AVRMachineFunctionInfo` which allowed me to move the registry-checking stuff directly into`AVRExpandPseudo` pass, simplifying rest of the code; I think it's the cleaner approach for the issue posted on that MR.

This is my first merge request to LLVM, so probably the quality is subpar, but I'm ofc. open to any comments; thanks! :-)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114611

Files:
  llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp
  llvm/lib/Target/AVR/AVRFrameLowering.cpp
  llvm/lib/Target/AVR/AVRMachineFunctionInfo.h
  llvm/test/CodeGen/AVR/bug-2021-01-29-complex-frame-pointer-usage.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114611.389870.patch
Type: text/x-patch
Size: 8748 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211125/41bcd7de/attachment.bin>


More information about the llvm-commits mailing list