[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake Egan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 25 10:53:38 PST 2021


Jake-Egan added inline comments.


================
Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1
+// UNSUPPORTED: powerpc64-ibm-aix
 // RUN: rm -rf %t.dir
----------------
jsji wrote:
> there is no `fmodule-format=obj` here, why are we failing here?
> 
They have the same error as the other tests:

```
64-bit XCOFF object files are not supported yet.
```


================
Comment at: clang/test/lit.cfg.py:259
+if 'aix' in config.target_triple:
+    for directory in ('/CodeGenCXX', '/Misc', '/Modules', '/PCH'):
+        exclude_unsupported_files_for_aix(config.test_source_root + directory)
----------------
jsji wrote:
> Why not adding `ASTMerge` and its subfolders?
Adding those folders were causing regressions:

```
Clang :: utils/update_cc_test_checks/global-hex-value-regex.test
Clang :: utils/update_cc_test_checks/global-value-regex.test
```
With error:

```
did not discover any tests for provided path(s)
```

I think because the only test in the folder gets excluded, so LIT can't find any test to run.

I could create a lit.local.cfg in each `ASTMerge` subfolder to unsupport each one if that's preferred.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113049/new/

https://reviews.llvm.org/D113049



More information about the llvm-commits mailing list