[llvm] 9300b13 - Revert "[InstCombine] (~(a | b) & c) | ~(c | (a ^ b)) -> ~((a | b) & (c | (b ^ a)))"

[Mekhanoshin, Stanislav via llvm-commits]

[AMD Official Use Only]

That's too late now, but the second transformation was only correct with no undef inputs. I don't believe that has really affected anyone practically though.

Stas
________________________________
From: Florian Hahn <florian_hahn at apple.com>
Sent: Thursday, November 25, 2021 2:44:43 AM
To: Mekhanoshin, Stanislav <Stanislav.Mekhanoshin at amd.com>; Stanislav Mekhanoshin <llvmlistbot at llvm.org>
Cc: llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>
Subject: Re: [llvm] 9300b13 - Revert "[InstCombine] (~(a | b) & c) | ~(c | (a ^ b)) -> ~((a | b) & (c | (b ^ a)))"

[CAUTION: External Email]

Hi,

> On Nov 24, 2021, at 19:14, Stanislav Mekhanoshin via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Stanislav Mekhanoshin
> Date: 2021-11-24T11:14:52-08:00
> New Revision: 9300b133c80dfc1a15135f9fb9c5afaf8a6805f8
>
> URL: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F9300b133c80dfc1a15135f9fb9c5afaf8a6805f8&data=04%7C01%7CStanislav.Mekhanoshin%40amd.com%7C8dbf308f7c41432b276e08d9b0009912%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637734338899105891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4YjURD%2B195eCOiOZB6QjhmRLCHU2yMJxFmWHeH1jIak%3D&reserved=0
> DIFF: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F9300b133c80dfc1a15135f9fb9c5afaf8a6805f8.diff&data=04%7C01%7CStanislav.Mekhanoshin%40amd.com%7C8dbf308f7c41432b276e08d9b0009912%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637734338899105891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ZV%2FlAqavxahKeHKZ7w4YBYtHjU0L5RBbEwb8BE6qqVk%3D&reserved=0
>
> LOG: Revert "[InstCombine] (~(a | b) & c) | ~(c | (a ^ b)) -> ~((a | b) & (c | (b ^ a)))"
>
> This reverts commit c407769f5e6c81d56de0b251aed5750a16a7651c.


It would be great if you could include a reason for the revert in the commit message, so it is a bit easier to see what issue the revert addresses for people following along.

Cheers,
Florian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211125/4a5c0d18/attachment.html>