[PATCH] D113420: [WebAssembly] Implement table instruction intrinsics and ref.null

[Paulo Matos via Phabricator via llvm-commits]

pmatos planned changes to this revision.
pmatos added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrRef.td:18
+                        [(set rc:$dst,
+                           (!cast<Intrinsic>("int_wasm_ref_null_" # ht)))],
+                        "ref.null\t$dst," # ht,
----------------
The problem I alluded to in https://reviews.llvm.org/D113420#3151549 happens here. Because I don't mention heaptype as inputs, the parser fails. But if I do add as inputs heaptype, and not in the instruction pattern (where the intrinsic is), then tablegen does not accept it. It makes, however, no sense to have heaptype as an argument since it can be suffix to the intrinsic name. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113420/new/

https://reviews.llvm.org/D113420