[PATCH] D114590: [CodeGen] Emit alignment "Max Skip" operand for align directives

Nicholas Guy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 25 06:57:14 PST 2021


NickGuy added a comment.

In D114590#3153774 <https://reviews.llvm.org/D114590#3153774>, @dmgreen wrote:

> Do we really want to add this to the base Align class? Or should it just be part of whatever controls the code alignment?

As far as I can tell, AsmPrinter::emitAlignment is what controls the code alignment. Beyond that point, all the parameters are either `unsigned` or `int64_t` types. I was hesitant to add it to Align, but this was the least-invasive solution I could come up with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114590/new/

https://reviews.llvm.org/D114590



More information about the llvm-commits mailing list