[PATCH] D114581: [RISCV] Fix a crash in decoding LMUL in VTYPE

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 25 05:54:05 PST 2021


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/RISCV/vsetvli.s:5-7
+# CHECK: 0: d7 75 85 01 vsetvli a1, a0, e64, m1, tu, mu
+# CHECK: 4: d7 75 c5 01 vsetvli a1, a0, e64, <reserved LMUL>, tu, mu
+# CHECK: 8: d7 75 d5 01 vsetvli a1, a0, e64, mf8, tu, mu
----------------
Do you need to test the addresses/raw instruction bytes for this test to be valid?

Also, can you use CHECK-NEXT for the second and third lines here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114581/new/

https://reviews.llvm.org/D114581



More information about the llvm-commits mailing list