[PATCH] D114588: [DebugInfo][InstrRef] "Final" test cleanup switching x86 tests to instruction referencing

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 25 05:49:58 PST 2021


jmorse created this revision.
jmorse added reviewers: StephenTozer, Orlando, TWeaver, djtodoro.
Herald added subscribers: pengfei, qcolombet, MatzeB.
jmorse requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

These are some final test changes for using instruction referencing on X86:

- Most of these tests just have the flag switched so that they run with instr-ref, and just work: these tests were fixed by earlier patches.
- One or two have minor differences in how debug values are printed in textual output,
- A couple have different temporary labels in the text asm output, due to more MCSymbols being created in the output. The actual variable locations don't change.
- One test checking for "debug-location !1234" at the end of DBG_VALUEs is modified because InstrRefBasedLDV creates new DILocations for variable locations, they don't get assigned metadata node numbers, and are instead represented inline. This test isn't checking for line number information though, so it's not important.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114588

Files:
  llvm/test/CodeGen/MIR/X86/diexpr-win32.mir
  llvm/test/CodeGen/X86/fast-regalloc-live-out-debug-values.mir
  llvm/test/DebugInfo/COFF/fpo-shrink-wrap.ll
  llvm/test/DebugInfo/COFF/fpo-stack-protect.ll
  llvm/test/DebugInfo/COFF/types-array-advanced.ll
  llvm/test/DebugInfo/MIR/X86/entry-value-of-modified-param.mir
  llvm/test/DebugInfo/MIR/X86/kill-entry-value-after-diamond-bbs.mir
  llvm/test/DebugInfo/MIR/X86/live-debug-values-restore.mir
  llvm/test/DebugInfo/X86/dbg-addr-dse.ll
  llvm/test/DebugInfo/X86/live-debug-variables.ll
  llvm/test/DebugInfo/X86/sdag-split-arg.ll
  llvm/test/DebugInfo/X86/sdagsplit-1.ll
  llvm/test/tools/llvm-locstats/locstats.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114588.389754.patch
Type: text/x-patch
Size: 10370 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211125/a7b6ea6a/attachment.bin>


More information about the llvm-commits mailing list