[PATCH] D114460: [fir] Add fir reduction builder

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: flang/include/flang/Optimizer/Builder/Runtime/RTBuilder.h:62
+template <>
+constexpr TypeBuilderFunc getModel<short int>() {
+  return [](mlir::MLIRContext *context) -> mlir::Type {
----------------
clementval wrote:
> rovka wrote:
> > Can we get rid of all of this duplication by using std::is_integral etc?
> Not sure I see where do you want us to go here. Do you have an example? 
Moved discussion to https://reviews.llvm.org/D114557


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114460/new/

https://reviews.llvm.org/D114460