[PATCH] D114557: [fir] Add base for runtime builder unittests

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 25 03:39:10 PST 2021


clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/unittests/Optimizer/Builder/Runtime/RuntimeCallTestBase.h:86
+
+static void checkCallOpFromResultBox(mlir::Value result,
+    llvm::StringRef fctName, unsigned nbArgs, bool addLocArgs = true) {
----------------
rovka wrote:
> I think this needs a comment about exactly what it's checking (e.g. some fir snippet), so it's easier for people to know when to use it.
Added some comments. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114557/new/

https://reviews.llvm.org/D114557



More information about the llvm-commits mailing list