[PATCH] D114453: [unroll] Split full exact and full bound unroll costing [NFC]

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp:957
+      shouldFullUnroll(L, TTI, DT, SE, EphValues, TripCount, UCE, UP);
+    if (UnrollFactor) {
+      UP.Count = *UnrollFactor;
----------------
nit: it might also be a good opportunity to limit the scope of UnrollFactor to this block, e.g. by  `if (auto UnrollFactor = shouldFullUnroll(L, TTI, DT, SE, EphValues, TripCount, UCE, UP)) {} `



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114453/new/

https://reviews.llvm.org/D114453