[PATCH] D114422: [VP] Propagate align parameter attr on VP load/store to ISel

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/docs/LangRef.rst:19645
+The :ref:`align <attr_align>` parameter attribute can be provided for the first
+argument.
+
----------------
craig.topper wrote:
> The previous paragraph called this "first operand" now we're using "first argument".
You make a good argument (sorry!). I've fixed that up.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7364
         MachinePointerInfo(PtrOperand), MachineMemOperand::MOLoad,
         VT.getStoreSize().getKnownMinSize(), *Alignment, AAInfo, Ranges);
     LD = DAG.getLoadVP(VT, DL, InChain, OpValues[0], OpValues[1], OpValues[2],
----------------
craig.topper wrote:
> Not related to this patch, but should we be using UnknownSize here after D113888. At least if the mask isn't all ones.
Yeah thanks for reminding me. I saw that patch go through and was going to check what was needed for VP. I'll create a note for myself to come back to this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114422/new/

https://reviews.llvm.org/D114422