[PATCH] D109416: getVPMemoryOpCost interface

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:1387
+  /// Use of %evl is discouraged when that is not the case.
+  bool hasActiveVectorLength(Type *DataType, Align Alignment) const;
 
----------------
This is really just a getter that tells you whether using VP intrinsics makes sense on this target at all. It shouldn't be modified this way.

Couldn't you use the cost function to tell you whether a combination of %evl and type for memory accesses makes sense?




================
Comment at: llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp:1341
+
+bool PPCTTIImpl::hasActiveVectorLength(Type *DataType, Align Alignment) const {
+  // TODO
----------------
This patch should only be for TTI. You are using the default impl here anyway - target-specific changes should go in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109416/new/

https://reviews.llvm.org/D109416