[PATCH] D110827: [LLDB] Provide target specific directories to libclang
Raphael Isemann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 24 23:17:02 PST 2021
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for fixing this!
================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.cpp:86
- // Check for /usr/include. On Linux this might be /usr/include/bits, so
- // we should remove that '/bits' suffix to get the actual include directory.
- if (posix_dir.endswith("/usr/include/bits"))
- posix_dir.consume_back("/bits");
- if (posix_dir.endswith("/usr/include"))
- return m_c_inc.TrySet(posix_dir);
+ llvm::Optional<llvm::StringRef> inc_path;
+ // Target specific paths contains /usr/include, so we check them first
----------------
This can be moved to the assignments below (and then the double parenthesis can disappear too).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110827/new/
https://reviews.llvm.org/D110827
More information about the llvm-commits
mailing list